Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(store): deprecate selectors with props #2993

Merged
merged 2 commits into from
Apr 22, 2021
Merged

feat(store): deprecate selectors with props #2993

merged 2 commits into from
Apr 22, 2021

Conversation

timdeschryver
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Closes #2980

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@ngrxbot
Copy link
Collaborator

ngrxbot commented Apr 11, 2021 •
edited
Loading

Preview docs changes for 97ac4de at https://previews.ngrx.io/pr2993-97ac4de7/

@timdeschryver timdeschryver force-pushed the deprecate-selector-with-props branch from 18823c4 to 97ac4de Compare April 11, 2021 16:39
alex-okrushko
alex-okrushko approved these changes Apr 19, 2021
View reviewed changes
Copy link
Member

@alex-okrushko alex-okrushko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to add the update schematic for this to ease the migration? (not necessarily for now, but when we remove it)

MikeRyanDev
MikeRyanDev approved these changes Apr 20, 2021
View reviewed changes
Copy link
Member

@MikeRyanDev MikeRyanDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big fan of this change

@timdeschryver
Copy link
Member Author

@alex-okrushko we don't have a schematic to fix these selectors.
It's something we'll have to look into, because I'm not sure how we can provide a schematic that covers all cases. For example, props are passed to all selectors and I'm not sure if we can refactor all selectors without breaking something.

@brandonroberts brandonroberts merged commit 7c6d4e4 into master Apr 22, 2021
@brandonroberts brandonroberts deleted the deprecate-selector-with-props branch April 22, 2021 02:14
@markostanimirovic markostanimirovic mentioned this pull request Apr 29, 2021
Closed
@damienwebdev damienwebdev mentioned this pull request May 31, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikeRyanDev MikeRyanDev MikeRyanDev approved these changes

@alex-okrushko alex-okrushko alex-okrushko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RFC: Deprecate Selectors With Props
5 participants
@timdeschryver @ngrxbot @alex-okrushko @MikeRyanDev @brandonroberts